On Tue, Mar 24, 2020 at 09:10:18AM +0100, Christoph Zwerschke wrote: > Maybe where we release binaries (currently only for Windows) we could ship > them with a matching libql dll that will be installed with Pip alongside the > PyGres dll? I thinnk that would require the windows version of rpath which (depending on who you ask) is discouraged.
> Or maybe link the pqlib statically into the PyGres dll in that > case? This would make it even more convenient for Windows users since they > don't need to install Postgres. +1 Here, you talked about various compile-time switches. https://github.com/PyGreSQL/PyGreSQL/issues/12 I guess it's good to continue supporting those, at least for newly-added symbols that we *know* aren't in old releases. What's out there seems to be working for everyone. The old stuff can be removed eventually. I like this: if self.escaping_funcs and pg_version >= (9, 0): define_macros.append(('ESCAPING_FUNCS', None)) That allows a packager to disable a feature if they want the ability to run against old libpq. -- Justin _______________________________________________ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
