Am 25.03.2020 um 02:20 schrieb Justin Pryzby:
> The old stuff can be removed eventually. I like this:
>
> if self.escaping_funcs and pg_version >= (9, 0):
> define_macros.append(('ESCAPING_FUNCS', None))
> That allows a packager to disable a feature
> if they want the abilityto run> against old libpq.
The problem is that these switches are by default set to true. The idea
was that you set them to false on the command line if you don't want
these features to be compiled. However, I think that never worked since
you simply can't set these flags to false on the command line, you only
can set them to true by specifying the names of the options (i.e. pass
--escaping-funcs as option).
So we need to change that and instead use the negatives of these flags
everywhere as options i.e. "no_escaping_funcs" in this case. I usually
avoid negative forms since "Can I not have my coffee with no sugar"
sounds silly when I can say "Can I have coffee with sugar". But in the
case where "sugar" is always the default, it's ok, since you only need
to say "no sugar please" and never need to ask for sugar explicitly. (I
hope this was not confusing :)
-- Christoph
_______________________________________________
PyGreSQL mailing list
PyGreSQL@Vex.Net
https://mail.vex.net/mailman/listinfo/pygresql
