It appeared to me that Makespec.py just added the line 'icon=icon.ico' to the spec file; does it do more than that? I have a spec file containing a lot of hand-written lines (for files to be included in the executable). I ran Makespec with the --icon parameter and generated a new spec file and it appeared that it just added the 'icon=' line, so then I just added that to my hand-written spec file, but the icon part has never worked. Does running Makespec.py do more than just create the spec file?
Peter On Thu, Apr 29, 2010 at 1:41 AM, Giovanni Bajo <[email protected]> wrote: > On Wed, 28 Apr 2010 21:08:21 -0500, Peter Scheie <[email protected]> > wrote: > > Ah, clever idea! So, I tried that: I found two icon files in > > c:\pyinstaller\source\windows\, iconw.ico and icon1.ico. I renamed > those > > and then dropped in two copies of my icon and gave the the names > iconw.ico > > and icon1.ico; then I rebuild my executable...and it still came out with > > the > > pyinstaller icon. I don't know how that's possible since I change the > > names > > of the original icon files. And those were the only icon files I found > in > > c:\pyinstaller. I even tried copying in Sebastion's icon into > > c:\pyinstaller\source\windows\, naming the files iconw.ico and icon1.ico > > again; and again, when I run Build.py, I get the default pyinstaller > icon. > > I tried it with an icon file specified in my spec file and with no icon > > specified in the spec file; same result. Since I renamed the original > icon > > files, where is pyinstaller getting the icon from? > > The bulk icon is already part of the binary bootloader (see > support/loader/*.exe: they already have icons). The files you deleted would > affect recompilation of the bootloader, which is usually not performed on > Windows. > > If you specify an icon with Makespec.py, the icon should be inserted into > the executable, overwriting the bulk one. I have no idea why the process > fails for you. > -- > Giovanni Bajo :: [email protected] > Develer S.r.l. :: http://www.develer.com > > My Blog: http://giovanni.bajo.it > > -- > You received this message because you are subscribed to the Google Groups > "PyInstaller" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<pyinstaller%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/pyinstaller?hl=en. > > -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pyinstaller?hl=en.
