I should add that before I run Build.py, I delete the build directory that Build.py creates, to make sure nothing bad is carrying over from a previous attempt/build. I am not creating a new spec file each time, just re-running Build.py. Is that sufficient for a clean build?
On Thu, Apr 29, 2010 at 11:00 AM, Peter Scheie <[email protected]> wrote: > Sorry, I'll try to provide more details than just "I don't see the icon". > Using Anywhere PE Viewer, I looked at the resources of my executable and the > only icon in there is the default pyinstaller icon. So, I looked at > Build.py and through trial and error found that the name of my icon is > assigned to self.icon at ~line 635 (in the __init__() method) but in the > check_guts() method, at around line 685 the line 'data = > Target.get_guts(self, last_build)' results in data equaling None, which > means icon is never defined within check_guts (but perhaps it doesn't matter > there?). It looks like config['hasRsrcUpdate'] is never true (should it > be?) so CopyIcons() never runs and the icon doesn't get pulled in. > > I'll keep digging, but I wanted to mention these things in case anything > obviously wrong is evident. > > Peter > > > On Thu, Apr 29, 2010 at 9:04 AM, Giovanni Bajo <[email protected]> wrote: > >> On 4/29/2010 3:53 PM, Peter Scheie wrote: >> >>> It appeared to me that Makespec.py just added the line 'icon=icon.ico' >>> to the spec file; does it do more than that? >>> >> >> No, that's all. Sebastian's analysys is correct. You would need to debug >> why CopyIcons() does not work for you, and you are not providing us with >> many more information than "I don't see the icon". >> >> For instance, try downloading a tool that dumps the resources of a binary, >> and see what happens when you add the icon. >> -- >> Giovanni Bajo >> >> Develer S.r.l. >> http://www.develer.com >> >> -- >> You received this message because you are subscribed to the Google Groups >> "PyInstaller" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<pyinstaller%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/pyinstaller?hl=en. >> >> > -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pyinstaller?hl=en.
