Il giorno 10/mag/2012, alle ore 21:19, Don Dwiggins ha scritto:

> I have a question (I've run across this while working on Ticket #547, but 
> it's independent of Merge):
> 
> In EXE.check_guts, the first thing done is a call to _rmdir to remove the 
> folder containing the executable.  The next thing is to see whether the exe 
> exists.  Of course it doesn't, so the function returns True (need to 
> rebuild), and the following code will never be executed.
> 
> So, what is the intended effect here?  It looks like the _rmdir was added at 
> some point, possibly because it was decided that the existing executable 
> couldn't be trusted.
> 
> This isn't a major issue, but I am curious.


Well, it's totally a bug.

It's been introduced in Florian's first commit for Python 2.6 Windows support:

commit 9e1bbe9171dddde5032465d5f3aaa7e29aecd757
Author: Florian Höch <[email protected]>
Date:   Sun Mar 14 13:38:28 2010 +0000

    Create feature-branch for Python 2.6 support on Windows.
    Aim is to automatically resolve assembly dependencies.

It was not present in his last patch attached to ticket #39, where the work was 
being developed before Florian committed it to the SVN, so it's been added in 
the middle and escaped by code review.

Florian, why is it required? Can it be related to manifests in any way?
-- 
Giovanni Bajo   ::  [email protected]
Develer S.r.l.  ::  http://www.develer.com

My Blog: http://giovanni.bajo.it






-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/pyinstaller?hl=en.

Reply via email to