I have created a pull request for a proposed change where the function is renamed and only used where it makes sense (ie. in COLLECT and BUNDLE).
Am 11.05.2012 15:51, schrieb Florian Höch: > I agree the function could use some review though. The name is bad and > misleading (should probably be _rmpath instead), also the docstring is > incorrect. Sorry, my fault. Also, as pointed out by Don additional code > in check_guts after the function call seems superfluous and could be > removed. > > Am 11.05.2012 15:25, schrieb Florian Höch: >> The _rmdir change was not manifest or assembly related. It's a means to >> make sure that old files in the output directory are removed (which >> could otherwise happen if e.g. building in onedir mode after changing >> the analyzed python script to have less dependencies, ie. there could be >> .dll/.pyd/.so files left over in the output directory from a previous >> build). >> >> The initial discussion is here (starts py26win related, later posts are >> about output directory): >> http://groups.google.com/group/pyinstaller/browse_thread/thread/b8978062e08a49ba/05efa25f7c73b378 >> Which led to the patch proposal here: >> http://groups.google.com/group/pyinstaller/browse_thread/thread/36e3808f89a88cd2/35b9bfe3bffb3a3e > -- Florian Höch -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pyinstaller?hl=en.
