On Sat, Mar 26, 2022 at 10:11 AM Victor Stinner <vstin...@python.org> wrote:
> On Fri, Mar 25, 2022 at 7:04 PM Brett Cannon <br...@python.org> wrote: > > > > On Fri, Mar 25, 2022 at 4:23 AM Victor Stinner <vstin...@python.org> > wrote: > >> > >> I dislike the Tier 1 rule "All core developers are responsible to keep > >> these platforms, and thus ``main``, working." > >> > >> In my experience, "Everyone is reponsible" means in practice "nobody > >> is responsible". > > > > > > I don't think that applies here as you shouldn't even be merging a PR if > it breaks CI for these platforms. And if CI isn't good enough then we > should fix that. > > (...) > > But tier 1 is the CI we run on PRs, not in the Buildbot fleet. > > Oh ok. > > There is an old debate about differences between GitHub Actions and > Buildbots: > > * Buildbots run the test suite with "-u all" option. On Windows, > Python is built in debug mode. > * GHA uses "-u all,-cpu". On Windows, Python is built in release mode > (I think that changed last change after the 3rd buildbot failure not > catched by GHA but buildbots). > > A small number of regressions are not catched by GHA because of these > minor differences. It's a trade-off to keep the workflow efficient (be > able to merge a PR as soon as possible). > > I'm fine with this trade-off. But we must keep an eye on buildbots, > otherwise more changes are merged on top of the change introducing the > regression. > > -- > > If you consider that GHA are enough to prevent regressions for Tier 1, > does it mean that the "macOS" job must become mandatory? It's a x86_64 > platform. In my experience, this job is too slow and less reliable > than other GHA jobs. Maybe macOS should be pushed to Tier 2. Fixing > all macOS before a Python release is fine. But during the devcycle, > sometimes there are no enough available core devs to fix macOS > specific issues. Correct me if I'm wrong. I'm talking about the strong > Tier 1 requirements about the short delay to fix a regression, or > revert. > We can talk about it, but I personally wait until the macOS runs complete. I also hope that once merge queues <https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/using-a-merge-queue> go public (or we ask to get into the private beta) that it will help with any availability issues we have with macOS.
_______________________________________________ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/BMFPMNSDDYMB3YEUXE6ZAPPHOGGDRNYB/ Code of Conduct: https://www.python.org/psf/codeofconduct/
