On 18 février 10:14, Emile Anclin wrote: > On Thursday 18 February 2010 07:59:44 Sylvain Thénault wrote: > > On 17 février 01:38, Fletcher Johnson wrote: > > Hi, > > > > > I'm looking into fixing this bug, but I don't have a very good > > > understanding of where I should start tackling this bug. Can any > > > body recommend a file or a set of files in the source where I should > > > concentrate my efforts? > > > > * add a visit_raise method that will check the nature of the raised > > expression to detect potential misusage of a 2-uple > > I guess, you should actually add a *visit_assert* and check the type > of 'test' : > > def visit_assert(self, node): > if isinstance(node.test, astng.Tuple): > that_s_bad()
that's not enough, we should ensure that raise (a, b), 'bad' don't trigger the message > Maybe we want it in checkers/exceptions.py ? I would rather put it in base.py -- Sylvain Thénault LOGILAB, Paris (France) Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations Développement logiciel sur mesure: http://www.logilab.fr/services CubicWeb, the semantic web framework: http://www.cubicweb.org _______________________________________________ Python-Projects mailing list Python-Projects@lists.logilab.org http://lists.logilab.org/mailman/listinfo/python-projects
