On 18 février 11:40, Emile Anclin wrote:
> On Thursday 18 February 2010 11:21:55 Sylvain Thénault wrote:
> > > I guess, you should actually add a *visit_assert* and check the type
> > > of 'test' :
> > >
> > >     def visit_assert(self, node):
> > >         if isinstance(node.test, astng.Tuple):
> > >      that_s_bad()
> >
> > that's not enough, we should ensure that
> >
> >  raise (a, b), 'bad'
> >
> > don't trigger the message
> >
> 
> I thought, we are talking about *assert*, not *raise* ?

oops

> And shouldn't 
> 
>   assert (a, b), bad_msg
> 
> trigger the message too ?

nop. That's definitly intended, so we should raise any warning here.

-- 
Sylvain Thénault                               LOGILAB, Paris (France)
Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations
Développement logiciel sur mesure:       http://www.logilab.fr/services
CubicWeb, the semantic web framework:    http://www.cubicweb.org

_______________________________________________
Python-Projects mailing list
Python-Projects@lists.logilab.org
http://lists.logilab.org/mailman/listinfo/python-projects

Reply via email to