XZise added a comment. In https://phabricator.wikimedia.org/T109119#1697336, @bd808 wrote:
> In https://phabricator.wikimedia.org/T109119#1696169, @jayvdb wrote: > > > One of the easy checks in the original task description is not yet > > implemented: > > > > - There should be no I… references but instead always git commit hashes. > > > So I should not be able to make commit messages to refer to uncommitted > change sets (or a series of related changes cherry-picked to multiple > branches)? Is this desired so that commit history information is self > contained? I personally prefer that self containment and don't really see when a patch needs to reference a future patch. That future patch may get abandoned to the feature from that patch may get implemented on another patch. Afaik patches should only reference in the past. And in which case should a patch mention that it's going to be cherry picked in another branch? The same applies to the above, what happens if that cherry pick does not happen? And in any case that cherry pick references to the original patch it comes from. And what happens if the patch gets cherry picked into other branches and are thus not present in the original patch's message. Mentioning git commit hashes has the big advantage that you don't have to resolve them as I mention in the original post. In https://phabricator.wikimedia.org/T109119#1697336, @bd808 wrote: > I assume you would intend it to extend to D... references when we finally get > switched to Differential instead of Gerrit. I'm not sure how Differential actually works but alone for the reason I mention in the original post, that you need to resolve that manually or need Differential, it should apply to that too. Please note that, as John mentioned, the current implementation does not pose that limit, so even if it would be enabled it wouldn't be necessary. TASK DETAIL https://phabricator.wikimedia.org/T109119 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: jayvdb, Jdforrester-WMF, JanZerebecki, Legoktm, bd808, gerritbot, hashar, greg, Aklapper, pywikibot-bugs-list, XZise _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
