jayvdb added a comment. In https://phabricator.wikimedia.org/T109119#1697336, @bd808 wrote:
> In https://phabricator.wikimedia.org/T109119#1696169, @jayvdb wrote: > > > One of the easy checks in the original task description is not yet > > implemented: > > > > - There should be no I… references but instead always git commit hashes. > > > So I should not be able to make commit messages to refer to uncommitted > change sets (or a series of related changes cherry-picked to multiple > branches)? Is this desired so that commit history information is self > contained? I assume you would intend it to extend to D... references when we > finally get switched to Differential instead of Gerrit. @bd808, we would still put uncommitted sha1/whatever in commit messages, due to dependencies, but the patch would be -1'd until the dependencies are committed. The advantage is that with a checker, we can be confident that we'll be reminded to update git hashes if the dependencies were revised during code review and the referenced sha1 became obsolete. It also provides a helpful reminder that some retesting might be needed if the dependency changed before it was committed. The disadvantage is that the -1 can reduce the amount of code review the patch will see as it will be filtered out of some queries. TASK DETAIL https://phabricator.wikimedia.org/T109119 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: jayvdb, Jdforrester-WMF, JanZerebecki, Legoktm, bd808, gerritbot, hashar, greg, Aklapper, pywikibot-bugs-list, XZise _______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
