DrTrigon added a comment.
In https://phabricator.wikimedia.org/T76211#2091018, @jayvdb wrote: > More docstrings, especially module level docstrings, would be especially helpful, but structurally it looks very good to me. Give @DrTrigon a day or two to look at it before publishing. I agree with docstrings, it should give an nice docu with sphinx and or doxygen. I would be very happy, if I could get more than 2 days - more like 1 week or so... as I am not in wiki anymore partly due to this rush all the time. Thanks. In https://phabricator.wikimedia.org/T76211#2091114, @AbdealiJK wrote: > Hi, > > Just an FYI here. I've made a development release of pycolornames as @jayvdb was ok with it. > You can see that at https://pypi.python.org/pypi/pycolorname > > Also, I've set it up so we have "nightly builds" whenever any Pull Request is merged using `rultor`. > When @DrTrigon completes his review I will release a stable version. So first I would to tanks you for your work! I downloaded pycolorname-0.0.1.dev20160305125219.tar.gz and examined it as well as the pypi page at https://pypi.python.org/pypi/pycolorname. I think we still have some work to do in order to make the first major relase: 1. I totally miss credits for other developers involved as well as proper licensing for http://www.pantonepaint.co.kr, http://www.logodesignteam.com, http://www.cal-print.com as well as http://www.ralcolor.com (it's questionable to me whether we should mention them at all - actually we would have to pay license fees to pantone to get such a table - these web pages have been kind or careless enough such that we were able to get the data - at least for once ;) - however you can mention Pantone and RAL - https://en.wikipedia.org of course. I don't like insisting on that stuff but I think we have to do this properly. 2. There are formatting issues on the pypi page. 3. I cannot compare databases under pycolorname/data/ easily due to changed format. I would have to sit down and write code for comparison. Is JSON faster than pickle for that size of data? 4. Extending on jayvdb's comment I have to ask for docu containing examples, that explain how to use the code (I currently don't understand how, sorry). Therefore I cannot comment on the code yet. To extend on 4. a bit more, basically we should implement something like in assignColorNames done: - a method that allows to search for a color's name given the RGB value of that color - this method should return the most close match out of the set of names we have in the database and the distance (colormath) - this assignments for every RGB value could be pre-calculated and stored in a DB in advance as well - not sure whether I tried this once but the DB was insanely big... - we should give it a try, it would speed the code up and remove the colormath dependency for end-users This is what I've found so far - all the best! TASK DETAIL https://phabricator.wikimedia.org/T76211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK, DrTrigon Cc: Vlkyrie, DrTrigon, Aklapper, jayvdb, valhallasw, pywikibot-bugs-list, Anshoe _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
