DrTrigon added a comment.
> 1. Could you elaborate on how to do this ? I am not familiar with how to credit appropriately. The questions I have on this point are: > - Where else should I credit developers ? (Currently Ive written your name as author in pypi and my name as maintainer - each of these can only be 1 name according to PEPs) > - Who are the other developers ? (The git log showed only your name) I only know of me as contributor - so if nothing else happened meanwhile, it's you and me. > - How do we mention the sources ? (Should I remove them from the readme?) I would remove the sources from the readme, yes but you can keep them in the code and comments of course. But may be not at the most prominet place... ;) > 3. In general json is supposed to be faster. The reason I personally prefer json is because it's human readable and easy to parse by anything. Note: > - The colors from the pickle should be the same for most of them (I will check this myself and probably add a test for it too). Where is the test script located? (you mentioned something in a mail) > - The colors for cal-print source are different because it seems `colormath` changed it's implementation of `delta_e`. And they do not have docs nor code of the older releases so I'm unable to verify which method of computing delta_e they used. Indeed this is a good point. So we should include our own calculation method according to the international standards. Did you try to get in contact with the colormath developer? > 4. Yes, docs are important. Will make them :) Created https://github.com/AbdealiJK/pycolorname/issues/23 to handle this Write a very brief first example into the readme/pypi page, that will alrady allow others to get started with. > I have planned assignColorName like functionality check here <https://github.com/AbdealiJK/pycolorname/issues/24> but I think it's best for a second release - as I'd like to read up on colortheory a bit more before doing that. So I was thinking after the gsoc proposal deadline. ...nice - so again we need colomath functionality included - good to see that you are working on it. Please include good literature into the docu as well, that important as a reference for later. Greetings TASK DETAIL https://phabricator.wikimedia.org/T76211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK, DrTrigon Cc: Vlkyrie, DrTrigon, Aklapper, jayvdb, valhallasw, pywikibot-bugs-list, Anshoe _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
