AbdealiJK added a comment.
Hey, I believe everything has been already addressed except the following: JSON vs pickle -------------- Even if speed is worse in json, I'd prefer it because human readable. We do not have a complicated class that requires pickling. This can easily have other language wrappers if it's json :) delta_e for color-math ---------------------- There are multiple algorithms 76, 94, 2000, and cmc. I believe 2000 and cmc are popularly used, although there is no official standard. 2000 is the one color-math used to use by default and now it asks users to decide which algorithm to use. I was using cmc, but now I changed to 2000. Using 2000 I still get some differences, but 656 out of 992 have the same color as earlier. (They've re-factored how the delta_e works completely and that seems to have caused some change ?) Well, either way - I think this is not something that is high priority, as we're just using the pantonepaint dataset in pycolorname. Test with older datasets ------------------------ This was complicated. Because the websites have changed and the old data was quite different sometimes. But I've gotten something up and running. I've added a deprecationTest which compares the data from the last time. You can find it here <https://github.com/AbdealiJK/pycolorname/blob/master/tests/deprecation_test.py> The email was just a quick way for you to convert pickle to json - you could easily use a difftool software to compare them then :) (But this test has explanations and is more detailed. You can ignore the email in favour of this) TASK DETAIL https://phabricator.wikimedia.org/T76211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Vlkyrie, DrTrigon, Aklapper, jayvdb, valhallasw, pywikibot-bugs-list, Anshoe _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
