jayvdb added a comment.

Currently I'm thinking of HTTP status codes, but I thought if a server returns something like 403 Forbidden, we should honour it instead.

Yea, that is reasonable.

Also in T113596 the website returned 200, but with invalid content.

Right, the user needs to explicitly add an entry; automatic fallback wont help with that one.

Unless there is a better way to detect failures

The best way to detect these websites is to try with the normal user-agent, then try a generated user-agent. The time to do this extra check is when the connection to the site is already established and open.

I'm considering submitting a first patch first, implementing per-module toggles .. and default behaviour exceptions ...

No worries splitting this into chunks, and stopping after each chunk to reconsider about whether it is wise to add more voodoo.
The first part is sufficient for a GCI task approval. I'm always happy to add more tasks to allow extra improvements to be done.


TASK DETAIL
https://phabricator.wikimedia.org/T152075

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dargasea, jayvdb
Cc: jayvdb, Aklapper, TerraCodes, pywikibot-bugs-list, Dargasea, Magul, MayS, Mdupont, JJMC89, Dalba, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to