On 03/25/2015 06:48 AM, Paolo Bonzini wrote: >> ## >> +# @COLOMode >> +# >> +# An enumeration of COLO mode.
s/mode/modes/
>> +#
>> +# @unprotected: COLO is not started or after failover
>> +#
>> +# @primary: Primary mode, the vm's state will be sent to secondary QEMU.
Inconsistent on whether you end with '.'
>> +#
>> +# @secondary: Secondary mode, receive the vm's state from primary QEMU.
>> +#
>> +# Since: 2.4
>> +##
>> +{ 'enum' : 'COLOMode',
>> + 'data' : ['unprotected', 'primary', 'secondary']}
>
> Perhaps replace COLOMode with ReplicationMode or FaultToleranceMode?
If you keep the name COLOMode, it would also be nice to spell out
'COurse-grain LOck-stepping' at least once somewhere in the .json file
(probably in the description of this enum). A name like ReplicationMode
is a bit more self-documenting (I know what replication is, I have to
look up what COLO is).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
