On 06/04/2015 06:20 PM, John Snow wrote:
> If we wish to make differential backups a feature that's easy to access,
> it might be pertinent to rename the "dirty-bitmap" mode to "incremental"
> to make it clear what /type/ of backup the dirty-bitmap is helping us
> perform.
> 
> This is an API breaking change, but 2.4 has not yet gone live,
> so we have this flexibility.

Agreed - I like the new name, and you are right that NOW is the time to
do it.

> 
> Signed-off-by: John Snow <js...@redhat.com>
> ---
>  block/backup.c            | 10 +++++-----
>  block/mirror.c            |  4 ++--
>  docs/bitmaps.md           |  8 ++++----
>  include/block/block_int.h |  2 +-
>  qapi/block-core.json      |  8 ++++----
>  qmp-commands.hx           |  6 +++---
>  tests/qemu-iotests/124    | 10 +++++-----
>  7 files changed, 24 insertions(+), 24 deletions(-)

Reviewed-by: Eric Blake <ebl...@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to