On 06/04/2015 06:20 PM, John Snow wrote: > Add the ability to copy one bitmap to a new bitmap. > > Signed-off-by: John Snow <js...@redhat.com> > --- > blockdev.c | 22 ++++++++++++++++++++++ > qapi/block-core.json | 16 ++++++++++++++++ > qmp-commands.hx | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 68 insertions(+)
[could be merged with 4]
>
> +void qmp_block_dirty_bitmap_copy(const char *node, const char *source,
> + const char *dest, Error **errp)
> +{
> + AioContext *aio_context;
> + BlockDriverState *bs;
> + BdrvDirtyBitmap *bitmap;
> +
> + if (!dest || dest[0] == '\0') {
qapi doesn't allow NULL for a mandatory option, so !dest is currently
dead code. Of course, someday I'd like to get rid of have_FOO arguments
for pointer types, with NULL possible on optional parameters, but that's
not happening any time soon.
But it's small enough, even if you leave it in, that I don't mind giving:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
