On 03/13/2018 11:17 AM, Kevin Wolf wrote:
From: John Snow <js...@redhat.com>

Instead of automatically transitioning from PENDING to CONCLUDED, gate
the .prepare() and .commit() phases behind an explicit acknowledgement
provided by the QMP monitor if auto_finalize = false has been requested.

+# @block-job-finalize:
+# Once a job that has manual=true reaches the pending state, it can be

Is this wording stale, given that you add two separate auto-* bool flags in 19/41? You may want to prepare a followup patch (doc bug fixes are safe during softfreeze, so it need not hold up this pull request) that tweaks this and any similar stale wording.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to