On Wed, Apr 16, 2025 at 8:12 PM Jamin Lin <jamin_...@aspeedtech.com> wrote:
>
> Move the I2C test case into a common helper function (do_ast2700_i2c_test) so
> it
> can be reused across multiple AST2700-based test cases. This reduces
> duplication
> and improves maintainability.
>
> Signed-off-by: Jamin Lin <jamin_...@aspeedtech.com>
Reviewed-by: Nabih Estefan <nabiheste...@google.com>
> ---
> tests/functional/test_aarch64_aspeed.py | 28 +++++++++++++------------
> 1 file changed, 15 insertions(+), 13 deletions(-)
>
> diff --git a/tests/functional/test_aarch64_aspeed.py
> b/tests/functional/test_aarch64_aspeed.py
> index c25c966278..441f7f3919 100755
> --- a/tests/functional/test_aarch64_aspeed.py
> +++ b/tests/functional/test_aarch64_aspeed.py
> @@ -18,6 +18,8 @@ class AST2x00MachineSDK(QemuSystemTest):
> def do_test_aarch64_aspeed_sdk_start(self, image):
> self.require_netdev('user')
> self.vm.set_console()
> + self.vm.add_args('-device',
> +
> 'tmp105,bus=aspeed.i2c.bus.1,address=0x4d,id=tmp-test')
> self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw',
> '-net', 'nic', '-net', 'user', '-snapshot')
>
> @@ -35,6 +37,17 @@ def do_test_aarch64_aspeed_sdk_start(self, image):
>
> 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.05/ast2700-default-obmc.tar.gz',
>
> 'c1f4496aec06743c812a6e9a1a18d032f34d62f3ddb6956e924fef62aa2046a5')
>
> + def do_ast2700_i2c_test(self):
> + exec_command_and_wait_for_pattern(self,
> + 'echo lm75 0x4d > /sys/class/i2c-dev/i2c-1/device/new_device ',
> + 'i2c i2c-1: new_device: Instantiated device lm75 at 0x4d');
> + exec_command_and_wait_for_pattern(self,
> + 'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '0')
> + self.vm.cmd('qom-set', path='/machine/peripheral/tmp-test',
> + property='temperature', value=18000)
> + exec_command_and_wait_for_pattern(self,
> + 'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input',
> '18000')
> +
> def start_ast2700_test(self, name):
> num_cpu = 4
> uboot_size = os.path.getsize(self.scratch_file(name,
> @@ -73,8 +86,6 @@ def start_ast2700_test(self, name):
> f'loader,addr=0x430000000,cpu-num={i}')
>
> self.vm.add_args('-smp', str(num_cpu))
> - self.vm.add_args('-device',
> -
> 'tmp105,bus=aspeed.i2c.bus.1,address=0x4d,id=tmp-test')
> self.do_test_aarch64_aspeed_sdk_start(
> self.scratch_file(name, 'image-bmc'))
>
> @@ -83,28 +94,19 @@ def start_ast2700_test(self, name):
> exec_command_and_wait_for_pattern(self, 'root', 'Password:')
> exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
>
> - exec_command_and_wait_for_pattern(self,
> - 'echo lm75 0x4d > /sys/class/i2c-dev/i2c-1/device/new_device ',
> - 'i2c i2c-1: new_device: Instantiated device lm75 at 0x4d');
> - exec_command_and_wait_for_pattern(self,
> - 'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '0')
> - self.vm.cmd('qom-set', path='/machine/peripheral/tmp-test',
> - property='temperature', value=18000)
> - exec_command_and_wait_for_pattern(self,
> - 'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input',
> '18000')
> -
> def test_aarch64_ast2700_evb_sdk_v09_05(self):
> self.set_machine('ast2700-evb')
>
> self.archive_extract(self.ASSET_SDK_V905_AST2700)
> self.start_ast2700_test('ast2700-a0-default')
> + self.do_ast2700_i2c_test()
>
> def test_aarch64_ast2700a1_evb_sdk_v09_05(self):
> self.set_machine('ast2700a1-evb')
>
> self.archive_extract(self.ASSET_SDK_V905_AST2700A1)
> self.start_ast2700_test('ast2700-default')
> -
> + self.do_ast2700_i2c_test()
>
> if __name__ == '__main__':
> QemuSystemTest.main()
> --
> 2.43.0
>
