Hi

On Mon, Apr 28, 2025 at 4:08 PM Dietmar Maurer <diet...@proxmox.com> wrote:
>
> > In file included from /home/elmarco/src/qemu/include/ui/console.h:4,
> >                  from ../system/runstate.c:54:
> > /home/elmarco/src/qemu/include/ui/qemu-pixman.h:10:10: fatal error:
> > pixman.h: No such file or directory
> >    10 | #include <pixman.h>
> >       |          ^~~~~~~~~~
>
> Just noticed that after updating to latest qemu.
>
> The following change fixes the problem, but I an not
> sure if we can simply depend on pixman there?

That shouldn't be a problem. Alternatively, perhaps split the vnc API
in ui/vnc.h ?

>
> --------------------------------------------
> diff --git a/meson.build b/meson.build
> index 50a9a2b036..2dfb1b1a4f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4073,10 +4073,11 @@ libsystem = static_library('system',
>                             libsystem_ss.sources() + genh,
>                             c_args: ['-DCONFIG_SOFTMMU',
>                                      '-DCOMPILING_SYSTEM_VS_USER'],
> -                           dependencies: libsystem_ss.dependencies(),
> +                           dependencies: [libsystem_ss.dependencies(), 
> pixman],
>                             build_by_default: false)

better in system/meson.build

>  libsystem = declare_dependency(objects: 
> libsystem.extract_all_objects(recursive: false),
>                                 dependencies: libsystem_ss.dependencies())
> --------------------------------------------
>


-- 
Marc-André Lureau

Reply via email to