On 6/30/25 07:09, Philippe Mathieu-Daudé wrote:
Only allow disabling NEON when using TCG.

This avoids confusing user experience:

   $ qemu-system-aarch64 -M virt -accel hvf \
                         -cpu host,neon=off,vfp=off,vfp-d32=off
   qemu-system-aarch64: AArch64 CPUs must have both VFP and Neon or neither

   $ qemu-system-aarch64 -M virt -accel hvf \
                         -cpu host,neon=off,vfp=off,vfp-d32=off
   qemu-system-aarch64: ARM CPUs must have both VFP-D32 and Neon or neither

   $ qemu-system-aarch64 -M virt -accel hvf \
                         -cpu host,neon=off,vfp=off,vfp-d32=off
   qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 
'host-arm-cpu.vfp-d32' not found

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  target/arm/cpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index ab5fbd9b40b..b6a8ba83a46 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1810,7 +1810,7 @@ static void arm_cpu_post_init(Object *obj)
if (arm_feature(&cpu->env, ARM_FEATURE_NEON)) {
          cpu->has_neon = true;
-        if (!kvm_enabled()) {
+        if (tcg_enabled() || qtest_enabled()) {
              qdev_property_add_static(DEVICE(obj), &arm_cpu_has_neon_property);
          }
      }

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~

Reply via email to