On 19/10/25 23:02, Bernhard Beschow wrote:
Signed-off-by: Bernhard Beschow <[email protected]>
---
  hw/rtc/mc146818rtc.c | 14 +++-----------
  hw/rtc/trace-events  |  4 ++++
  2 files changed, 7 insertions(+), 11 deletions(-)


diff --git a/hw/rtc/trace-events b/hw/rtc/trace-events
index b9f2852d35..d2f36217cb 100644
--- a/hw/rtc/trace-events
+++ b/hw/rtc/trace-events
@@ -32,6 +32,10 @@ m48txx_nvram_io_write(uint64_t addr, uint64_t value) "io write 
addr:0x%04" PRIx6
  m48txx_nvram_mem_read(uint32_t addr, uint32_t value) "mem read addr:0x%04x 
value:0x%02x"
  m48txx_nvram_mem_write(uint32_t addr, uint32_t value) "mem write addr:0x%04x 
value:0x%02x"
+# mc146818rtc.c
+mc146818_rtc_ioport_read(uint8_t addr, uint8_t value) "[0x%02" PRIx8 "] -> 
0x%02" PRIx8
+mc146818_rtc_ioport_write(uint8_t addr, uint8_t value) "[0x%02" PRIx8 "] <- 
0x%02" PRIx8

The block could be theorically mapped anywhere in the I/O ISA space,
so 'uint8_t addr' is a bit too restrictive here. Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

+
  # goldfish_rtc.c
  goldfish_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 
0x%08" PRIx64
  goldfish_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 
0x%08" PRIx64


Reply via email to