Re: [PATCH v3 08/10] hw/i386/apic: Ensure own APIC use in apic_msr_{read, write}

[Bernhard Beschow]

Am 20. Oktober 2025 06:09:22 UTC schrieb "Philippe Mathieu-Daudé" 
<phi...@linaro.org>:
>On 19/10/25 23:03, Bernhard Beschow wrote:
>> Avoids the `current_cpu` global and seems more robust by not "forgetting" the
>> own APIC and then re-determining it by cpu_get_current_apic() which uses the
>> global.
>> 
>> Signed-off-by: Bernhard Beschow <shen...@gmail.com>
>> ---
>>   include/hw/i386/apic.h               |  4 ++--
>>   hw/intc/apic.c                       | 10 ++--------
>>   target/i386/hvf/hvf.c                |  4 ++--
>>   target/i386/tcg/system/misc_helper.c |  4 ++--
>>   4 files changed, 8 insertions(+), 14 deletions(-)
>
>Good cleanup!
>
>Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Thanks! I think it would be possible to remove cpu_get_current_apic() entirely 
if each local APIC's memory region could be bound to the address space of each 
CPU. However, it seems that the respective root memory regions aren't prepared 
for that and I didn't want to go into this rabbit hole here in this context.

Best regards,
Bernhard