[!] Sending this again, to keep conversation *legally* correct, as this did not appear in the mailing-list when sent from my official ID.
Sorry for any inconvenience caused due to this. On Thu, Oct 23, 2025 at 4:14 AM Gavin Shan <[email protected]> wrote: > > Hi Salil, > > On 10/23/25 11:29 AM, Salil Mehta wrote: > > [...] > > >> > >> Ah, I see. I think I understand the issue. It's complaining > >> about calling the finalize twice. Is it possible to check as > >> I do not have a way to test it? > >> > >> > >> int kvm_arm_vcpu_finalize(struct kvm_vcpu *vcpu, int feature) > >> { > >> switch (feature) { > >> case KVM_ARM_VCPU_SVE: > >> [...] > >> if (kvm_arm_vcpu_sve_finalized(vcpu)) > >> return -EPERM;-----> this where it must be popping? > >> [...] > >> } > > > > I've pushed the fix to avoid calling the finalizing SVE > > feature (KVM_ARM_VCPU_FINALIZE) twice on the > > same RFC-V6.2 branch. > > > > May I kindly request you to validate the fix again and > > check SVE works on NVIDIA grace-hopper? > > > > With the latest rfc-v6.2 branch, I don't hit the issue. The vCPU can be hot > added > and removed on grace-hopper host. Excellent, SVE/SME and other ARM extensions have not been tested earlier. It would be of immense help if all of these can be validated as I do not have capable hardware to test them. Many thanks for your proactive efforts in reporting, reviewing the fixes and validating them as well. I appreciate it! For anyone who wants to try, fix is here: https://github.com/salil-mehta/qemu/commits/virt-cpuhp-armv8/rfc-v6.2 https://github.com/salil-mehta/qemu/commit/cd58e65a79c224a59407553c1a6288ed667b19ed Many thanks! Salil.
