On 2025/11/17 14:39, Akihiko Odaki wrote:
On 2025/11/17 14:51, Honglei Huang wrote:
The error handling logic was incorrect in virgl_cmd_resource_create_blob.
virtio_gpu_create_mapping_iov() returns 0 on success and non-zero on
failure, but the code was checking whether to set the error response.
The fix changes the condition from 'if (!ret)' to 'if (ret != 0)' to
properly handle the return value, consistent with other usage patterns
in the same codebase (see virtio-gpu.c:932 and virtio-gpu.c:354).
Signed-off-by: Honglei Huang <[email protected]>
Reviewed-by: Akihiko Odaki <[email protected]>
This should also have:
Fixes: 7c092f17ccee ("virtio-gpu: Handle resource blob commands")
Really thanks for the review, will add fixes tag in v2.
Regards,
Honglei
