Re: [PATCH v2 5/6] hw/arm/aspeed_ast27x0: Wire SGPIO controller to AST2700 SoC

[Cédric Le Goater]

On 12/9/25 01:01, Yubin Zou wrote:

This commit integrates the Aspeed SGPIO controller into the AST2700

Signed-off-by: Yubin Zou <yub...@google.com>
---
  hw/arm/aspeed_ast27x0.c | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)

diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index 
e5f04bd16e80696e41005d9062a6df6d060b8088..787accadbecae376d0c747d054ec6372785375b1
 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -519,6 +519,11 @@ static void aspeed_soc_ast2700_init(Object *obj)
      snprintf(typename, sizeof(typename), "aspeed.gpio-%s", socname);
      object_initialize_child(obj, "gpio", &s->gpio, typename);

+ snprintf(typename, sizeof(typename), "aspeed.sgpio-%s", socname);

+    for (i = 0; i < sc->sgpio_num; i++) {
+        object_initialize_child(obj, "sgpio[*]", &s->sgpiom[i], typename);
+    }
+
      object_initialize_child(obj, "rtc", &s->rtc, TYPE_ASPEED_RTC);

snprintf(typename, sizeof(typename), "aspeed.sdhci-%s", socname);

@@ -973,6 +978,17 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, 
Error **errp)
      sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio), 0,
                         aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_GPIO));

+ /* SGPIO */

+    for (i = 0; i < sc->sgpio_num; i++) {
+        if (!sysbus_realize(SYS_BUS_DEVICE(&s->sgpiom[i]), errp)) {
+            return;
+        }
+        aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->sgpiom[i]), 0,
+                        sc->memmap[ASPEED_DEV_SGPIOM0 + i]);
+        sysbus_connect_irq(SYS_BUS_DEVICE(&s->sgpiom[i]), 0,
+                        aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_SGPIOM0 + i));
+    }
+
      /* RTC */
      if (!sysbus_realize(SYS_BUS_DEVICE(&s->rtc), errp)) {
          return;

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.