Re: [SPAM] [PATCH v3 10/18] hw/arm/aspeed: Attach SPI device to AST1700 model

[Cédric Le Goater]

On 12/8/25 08:44, Kane Chen wrote:

From: Kane-Chen-AS <kane_c...@aspeedtech.com>

Connect the SPI device to AST1700 model.

Signed-off-by: Kane-Chen-AS <kane_c...@aspeedtech.com>
---
  include/hw/arm/aspeed_ast1700.h |  2 ++
  hw/arm/aspeed_ast1700.c         | 22 ++++++++++++++++++++++
  2 files changed, 24 insertions(+)

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast1700.h
index 23588f7a81..5b120dd11a 100644
--- a/include/hw/arm/aspeed_ast1700.h
+++ b/include/hw/arm/aspeed_ast1700.h
@@ -10,6 +10,7 @@

#include "hw/sysbus.h"

  #include "hw/misc/aspeed_ltpi.h"
+#include "hw/ssi/aspeed_smc.h"
  #include "hw/char/serial-mm.h"

#define TYPE_ASPEED_AST1700 "aspeed.ast1700"

@@ -25,6 +26,7 @@ struct AspeedAST1700SoCState {
      AspeedLTPIState ltpi;
      SerialMM uart;
      MemoryRegion sram;
+    AspeedSMCState spi;
  };

#endif /* ASPEED_AST1700_H */

diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c
index 8e93a8857a..62808f7c60 100644
--- a/hw/arm/aspeed_ast1700.c
+++ b/hw/arm/aspeed_ast1700.c
@@ -17,15 +17,19 @@
  #define AST1700_SOC_SRAM_SIZE        0x00040000

enum {

+    ASPEED_AST1700_DEV_SPI0,
      ASPEED_AST1700_DEV_SRAM,
      ASPEED_AST1700_DEV_UART12,
      ASPEED_AST1700_DEV_LTPI_CTRL,
+    ASPEED_AST1700_DEV_SPI0_MEM,
  };

static const hwaddr aspeed_ast1700_io_memmap[] = {

+    [ASPEED_AST1700_DEV_SPI0]      =  0x00030000,
      [ASPEED_AST1700_DEV_SRAM]      =  0x00BC0000,
      [ASPEED_AST1700_DEV_UART12]    =  0x00C33B00,
      [ASPEED_AST1700_DEV_LTPI_CTRL] =  0x00C34000,
+    [ASPEED_AST1700_DEV_SPI0_MEM]  =  0x04000000,
  };

static void aspeed_ast1700_realize(DeviceState *dev, Error **errp)

@@ -58,6 +62,20 @@ static void aspeed_ast1700_realize(DeviceState *dev, Error 
**errp)
                          aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_UART12],
                          sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->uart), 0));

+ /* SPI */

+    object_property_set_link(OBJECT(&s->spi), "dram",
+                             OBJECT(&s->iomem), errp);
+    if (!sysbus_realize(SYS_BUS_DEVICE(&s->spi), errp)) {
+        return;
+    }
+    memory_region_add_subregion(&s->iomem,
+                        aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SPI0],
+                        sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->spi), 0));
+
+    memory_region_add_subregion(&s->iomem,
+                        aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SPI0_MEM],
+                        sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->spi), 1));
+
      /* LTPI controller */
      if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) {
          return;
@@ -75,6 +93,10 @@ static void aspeed_ast1700_instance_init(Object *obj)
      object_initialize_child(obj, "uart[*]", &s->uart,
                              TYPE_SERIAL_MM);

+ /* SPI */

+    object_initialize_child(obj, "ioexp-spi[*]", &s->spi,
+                            "aspeed.spi0-ast2700");
+
      /* LTPI controller */
      object_initialize_child(obj, "ltpi-ctrl",
                              &s->ltpi, TYPE_ASPEED_LTPI);