Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: >> Hi, >> >> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: >>> Fixes a QEMU crash when passing dump_guest_core parameter in command line. >> >> Explain that, please? > > Pls note the submission date. It's 1 month late to ask for > basic clarifications. > > I've merged the patches, I'll fix up issues such as prettifying > includes by adding patches on top.
No, since the patch is not in qemu.git (it builds!) it is not too late to fix it, nor too late to ask why a patch that introduces a breakage does what it does. (Moving the info from the cover letter into the commit message would've been a good idea, Marcel.) All QEMU patches are supposed to be bisectable. It's our job as maintainers to build-test each. If you do that 1 month later, that's not my fault. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)