On Wed, Mar 11, 2015 at 08:34:09AM +0100, Markus Armbruster wrote: > Andreas Färber <afaer...@suse.de> writes: > > > Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > >> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: > >>> Hi, > >>> > >>> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: > >>>> Fixes a QEMU crash when passing dump_guest_core parameter in command > >>>> line. > >>> > >>> Explain that, please? > >> > >> Pls note the submission date. It's 1 month late to ask for > >> basic clarifications. > >> > >> I've merged the patches, I'll fix up issues such as prettifying > >> includes by adding patches on top. > > > > No, since the patch is not in qemu.git (it builds!) it is not too late > > to fix it, nor too late to ask why a patch that introduces a breakage > > does what it does. > > Getting review that late is decidedly suboptimal, but no excuse to > invoke maintainer privilege to ram the patch through unchanged. > > Cosmetic issues can be tidied up on top. The ongoing review may produce > nothing but cosmetic issues, but we don't know that, yet.
Cool, review is good. What I wanted to say though is that I'm not holding up a patchset that's been around for a month just because of cosmetics and basic questions. So I intend to send pull request this evening - I don't think we want to live with known crashers any longer - crashes waste tester's time. > Commit messages can't be tidied up on top, and they're dirt cheap to > improve right in place, so let's do that, please. > > [...] Sure. Marcel, can you pls supply the command line that produces the crash? I'll include that. -- MST
