On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas Färber wrote: > Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > > On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: > >> Hi, > >> > >> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: > >>> Fixes a QEMU crash when passing dump_guest_core parameter in command line. > >> > >> Explain that, please? > > > > Pls note the submission date. It's 1 month late to ask for > > basic clarifications. > > > > I've merged the patches, I'll fix up issues such as prettifying > > includes by adding patches on top. > > No, since the patch is not in qemu.git (it builds!) it is not too late > to fix it, nor too late to ask why a patch that introduces a breakage > does what it does.
I tried to say that I'm not holding this patch set up because there are some basic questions. Paolo reviewed it and gave an ack. If others want to re-start review 1 month afterwards, that's fine, but I don't want to defer pull request with this any longer. If someone can quickly spot a serious non-cosmetic problem there, that's another matter, and would make me defer the pull request. > (Moving the info from the cover letter into the > commit message would've been a good idea, Marcel.) I can tweak commit messages, sure, since that does not require re-testing it all. > All QEMU patches are supposed to be bisectable. It's our job as > maintainers to build-test each. If you do that 1 month later, that's not > my fault. > > Regards, > Andreas I have this patch in my tree and there's no bisect issue, just test-built before and after this patch. That's because I had the ifdefs in boards.h which you and Peter objected to, but that is about cosmetics, I fixed that with a patch on top to hopefully make you both happy. Don't take my word for it, you can check out my tree and verify, that would be very wellcome. > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, > Graham Norton; HRB 21284 (AG Nürnberg)
