On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: > On 19 October 2015 at 10:17, Gerd Hoffmann <kra...@redhat.com> wrote: > > ---------------------------------------------------------------- > > fw_cfg: add dma interface, add strings via cmdline. > > > > ---------------------------------------------------------------- > > Hi. I'm afraid this fails 'make check': > > TEST: tests/fw_cfg-test... (pid=17533) > /i386/fw_cfg/signature: OK > /i386/fw_cfg/id: ** > ERROR:/home/petmay01/qemu/tests/fw_cfg-test.c:40:test_fw_cfg_id: > assertion failed (qfw_cfg_get_u32(fw_cfg, FW_CFG_ID) == 1): (3 == 1) > FAIL > > (same failure on 64-bit ARM, ppc64be, OSX, 32-bit ARM). > > Windows fails to compile: > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function > ‘fw_cfg_dma_mem_read’: > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning: > integer constant is too large for ‘long’ type
I don't have a Windows test environment, but I suspect the following: #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */ should be changed to: #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */ If that sounds right, I'll respin the last patch. -Kevin
