On Mon, Oct 19, 2015 at 01:02:41PM +0100, Peter Maydell wrote: > On 19 October 2015 at 12:52, Kevin O'Connor <ke...@koconnor.net> wrote: > > On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: > >> Windows fails to compile: > >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function > >> ‘fw_cfg_dma_mem_read’: > >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning: > >> integer constant is too large for ‘long’ type > > > > I don't have a Windows test environment, but I suspect the following: > > > > #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */ > > > > should be changed to: > > > > #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */ > > Yes. All 64 bit constants should have an LL or ULL suffix.
Okay - I'll respin patch 7. > (The test failure is presumably something different.) I think the fix for the test failure is to make the test less picky (it should accept a feature bitmap of either 1 or 3). But I'll leave that to Marc or Gerd. -Kevin
