On 19 October 2015 at 12:52, Kevin O'Connor <ke...@koconnor.net> wrote: > On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: >> Windows fails to compile: >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function >> ‘fw_cfg_dma_mem_read’: >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning: >> integer constant is too large for ‘long’ type > > I don't have a Windows test environment, but I suspect the following: > > #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */ > > should be changed to: > > #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */
Yes. All 64 bit constants should have an LL or ULL suffix. (The test failure is presumably something different.) thanks -- PMM
