On Mon, Sep 5, 2016 at 5:31 PM, Paolo Bonzini <pbonz...@redhat.com> wrote:
>
>
> On 05/09/2016 13:59, Ashijeet Acharya wrote:
>>>> >> + if (has_migrate_set_speed) {
>>>> >> + qmp_migrate_set_speed(migrate_set_speed, NULL);
>>>> >> + }
>>>> >> + if (has_migrate_set_downtime) {
>>>> >> + qmp_migrate_set_downtime(migrate_set_downtime, NULL);
>>>> >> + }
>>> >
>>> > This is backwards; qmp_migrate_set_speed and qmp_migrate_set_downtime
>>> > should be implemented in terms of qmp_migrate_set_parameters, not the
>>> > other way round.
>>
>> Okay. Got it!
>
> Thinking more about it, it's even better to have two patches. One doing
> it this way (qmp_migrate_set_parameters calls the old functions), the
> second that reverses the direction.
>
Fine, I will send both the versions soon.
Ashijeet
> Thanks!
>
> Paolo
