On 05/09/2016 15:09, Ashijeet Acharya wrote: >>> >> + >>> >> "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?,migrate-set-speed:o?,migrate-set-downtime:T?", >> > >> > Same here about the names. Also use "i" for QMP commands. > I think we will have to use "T" for downtime at-least otherwise you > cant use float values for setting seconds like "0.2" for example. > No issues using "i" with bandwidth though.
Right, I should have mentioned that my remark was about the "o" (it caught my eye because of your change to hmp-commands.hx). Sorry! Paolo
