On Tue, 13 Sep 2016 09:49:09 -0500 Eric Blake <ebl...@redhat.com> wrote:
> On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote: > > The tap backend is already using qemu-bridge-helper to attach tap > > interface to a bridge but (unlike the bridge backend) it always uses > > the default bridge name - br0. > > > > This adds a "br" property support to the tap backend. > > > > Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> > > -- > > Changes: > > v2: > > * documented a new member in json and hx > > --- > > net/tap.c | 4 +++- > > qapi-schema.json | 3 +++ > > qemu-options.hx | 12 +++++++----- > > 3 files changed, 13 insertions(+), 6 deletions(-) > > > > > +++ b/qapi-schema.json > > @@ -2575,6 +2575,8 @@ > > # > > # @downscript: #optional script to shut down the interface > > # > > +# @br: #optional bridge name > > Missing a '(since 2.8)' designator. > > Also, we don't have to abbreviate; 'bridge-name' may be easier to > understand than 'br', as well as a mention of the default value if the > parameter is not supplied. > FWIW @br is consistent with what we already have in NetdevBridgeOptions since 1.2. > > +# > > # @helper: #optional command to execute to configure bridge > > # > > # @sndbuf: #optional send buffer limit. Understands [TGMKkb] suffixes. > > @@ -2604,6 +2606,7 @@ > > '*fds': 'str', > > '*script': 'str', > > '*downscript': 'str', > > + '*br': 'str', > > '*helper': 'str', > > '*sndbuf': 'size', > > '*vnet_hdr': 'bool', > > Oh, we already use underscore, so if you go with a longer name, > 'bridge_name' would be more consistent than 'bridge-name', even though > we prefer dash over underscore in new interfaces. >
pgpvWNnNpuL7y.pgp
Description: OpenPGP digital signature
