On 09/13/2016 11:23 PM, Alexey Kardashevskiy wrote: >>> >>> Also, we don't have to abbreviate; 'bridge-name' may be easier to >>> understand than 'br', as well as a mention of the default value if the >>> parameter is not supplied. > > > The existing NetdevBridgeOptions does not do this in json as well and it > does in qemu-options.hx, so does my patch. Do I have to fix a bridge first > before reposting this patch?...
If that interface is already baked in as 'br', then leave it alone. > > When exactly is the content of qapi-schema.json's comments shown to a user? Not yet, but Marc-Andre has patches pending that merge qemu-options.hx and qemu-schema.json so that we have a single file with documentation, rather than two semi-inconsistent copies. > > >>> >> >> FWIW @br is consistent with what we already have in NetdevBridgeOptions >> since 1.2. > > Right, this is why "br=". Okay, the argument of consistency with pre-existing interfaces is reasonable. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
