Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: > Make it easier to simulate various unusual hardware setups (for > example, recent commits 3482b9b and b8d0a98 affect the Dell > Equallogic iSCSI with its 15M preferred and maximum unmap and > write zero sizing, or b2f95fe deals with the Linux loopback > block device having a max_transfer of 64k), by allowing blkdebug > to wrap any other device with further restrictions on various > alignments. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > --- > v3: improve legibility of bounds checking, improve docs > v2: new patch > --- > qapi/block-core.json | 27 ++++++++++++++- > block/blkdebug.c | 96 > ++++++++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 120 insertions(+), 3 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index c29bef7..26f3e9f 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2068,6 +2068,29 @@ > # @align: #optional required alignment for requests in bytes, > # must be power of 2, or 0 for default > # > +# @max-transfer: #optional maximum size for I/O transfers in bytes, > +# must be multiple of the larger of @align and and 512
s/and and/and/ > +# (but need not be a power of 2), or 0 for default > +# (since 2.9) What is the reason for the 512 bytes restriction? Not really a problem, though, allowing more values later is easier than restricting them. The rest looks good. Kevin