On 12/07/2016 08:35 AM, Kevin Wolf wrote: >> +++ b/qapi/block-core.json >> @@ -2068,6 +2068,29 @@ >> # @align: #optional required alignment for requests in bytes, >> # must be power of 2, or 0 for default >> # >> +# @max-transfer: #optional maximum size for I/O transfers in bytes, >> +# must be multiple of the larger of @align and and 512 > > s/and and/and/ > >> +# (but need not be a power of 2), or 0 for default >> +# (since 2.9) > > What is the reason for the 512 bytes restriction?
Probably because I wrote the patch prior to your work to make blkdebug byte-based, and then forgot to touch it up on rebase. > Not really a problem, > though, allowing more values later is easier than restricting them. I'll see if I can drop the restriction, or at least improve the text, for v4. > > The rest looks good. > > Kevin > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature