On 01/11/2017 11:29 AM, Marc-André Lureau wrote: > This will help to split char.c in several units without having to > reference them all everywhere. This is useful in particular for tests. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > ---
> @@ -221,7 +222,7 @@ subdir-dtc:dtc/libfdt dtc/tests > dtc/%: > mkdir -p $@ > > -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(qom-obj-y) > $(crypto-aes-obj-$(CONFIG_USER_ONLY)) > +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) > $(chardev-obj-y) $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY)) Again, splitting long lines with \ would be nice, but not a necessity. > > ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS)) > # Only keep -O and -g cflags > diff --git a/Makefile.objs b/Makefile.objs > index cad4c54740..7985d21841 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -51,7 +51,7 @@ common-obj-$(CONFIG_POSIX) += os-posix.o > common-obj-$(CONFIG_LINUX) += fsdev/ > > common-obj-y += migration/ > -common-obj-y += chardev/ #aio.o > +common-obj-y += #aio.o The fact that aio.o is commented is unrelated to your patch, but now that this line is a comment only, can we delete it? > common-obj-y += page_cache.o Or maybe merge it with this line, so it doesn't look quite as odd? Nothing major, so Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
