On 01/11/2017 11:29 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > chardev/char-null.c | 31 +++++++++++++++++++++++++++++++ > chardev/char.c | 23 ----------------------- > chardev/Makefile.objs | 1 + > 3 files changed, 32 insertions(+), 23 deletions(-) > create mode 100644 chardev/char-null.c > > diff --git a/chardev/char-null.c b/chardev/char-null.c > new file mode 100644 > index 0000000000..18a49f5802 > --- /dev/null > +++ b/chardev/char-null.c > @@ -0,0 +1,31 @@ > +#include "qemu/osdep.h" > +#include "sysemu/char.h"
No copyright blurb? You should copy the header of chardev/char.c (since that's what you're splitting off of). Otherwise looks okay. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
