Eric Blake <ebl...@redhat.com> writes: > On 03/13/2017 01:18 AM, Markus Armbruster wrote: >> This reverts commit 3313b61's changes to tests/qapi-schema/, except >> for tests/qapi-schema/doc-*. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- > > Tested by doing: > > $ git checkout 3313b61 > $ git cherry-pick 07c7b92 # the current id on your qapi-doc branch > $ git diff HEAD^^ --stat tests/qapi-schema | grep -v /doc- > 72 files changed, 164 insertions(+) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > >> 200 files changed, 92 insertions(+), 1074 deletions(-) > > It's a shame we did that much busywork adding test documentation in the > first place. But it was incomplete (as I found out when trying to > convert some existing tests of failures into new tests of success, by > adding features like anonymous bases to flat unions), and indeed does > not add much value.
Marc-André initially reported missing documentation errors only in qapi2texi.py. I asked why in review of v5, he pointed to tests, I said "good point" and asked to put the explanation in the commit message. Got back "I fixed the tests instead (after all, we have complete control on what to accept or not. that was boring but now it's done)", felt a bit bad, and then felt bad some more when I made this patch.
