Marc-André Lureau <marcandre.lur...@gmail.com> writes: > Hi > > On Mon, Mar 13, 2017 at 10:36 AM Markus Armbruster <arm...@redhat.com> > wrote: > >> This reverts commit 3313b61's changes to tests/qapi-schema/, except >> for tests/qapi-schema/doc-*. >> >> > Do we expect those files to change? If not, or not much, I think i't s > rather better to keep the docs to exercise the parser in various > situations.
Point taken, but I think the proper way to exercise doc comments is systematic test cases in qapi-schema-test.json, or perhaps a separate test schema we create just for exercising doc comments. Probably should include a qapi2texi.py run complete with diff to golden .texi. > It doesn't reduce the merits of the doc pragma though for other > cases, which I wish I would have suggested (but I didn't like the initial > series to grow more features) We were both pretty desperate to get your work in without further delays.
