On Tue, 28 Nov 2017 15:17:38 +0100 Halil Pasic <pa...@linux.vnet.ibm.com> wrote:
> On 11/28/2017 02:46 PM, Cornelia Huck wrote: > > info qom-tree shows several devices under unattached that probably > > should go somewhere. > > I think this was reported by me. See > MID: <76f95c6f-641e-2fe0-73b4-3ab24fc1a...@linux.vnet.ibm.com> > > I would not mind a Reported-by: Halil Pasic <pa...@linux.vnet.ibm.com>. > Or do you see this differently? Apparently I forgot to add it to the first one. Will do. > > If these are bugs. I would prefer commit messages and titles reflecting > this fact. I don't see this as fixing bugs, more removing oddities. > > Otherwise at first glance both patches seem sane. Can I count this as an ack, or do you plan to do more review? > > Regards, > Halil > > > > > The css bridge should attach to the machine, as it has a similar > > purpose as e.g. a pci host bridge. > > > > The autogenerated network devices should be in the same bucket as any > > other device; I'm just not sure about the way I went about it. > > > > The zpci devices are still problematic: I don't have a good idea where > > they should show up. > > > > Remaining in the unattached container are the sysbus, memory regions > > and cpus. > > > > Cornelia Huck (2): > > s390x/css: attach css bridge > > s390x: attach autogenerated nics > > > > hw/s390x/css-bridge.c | 2 ++ > > hw/s390x/s390-virtio-ccw.c | 2 ++ > > 2 files changed, 4 insertions(+) > > >
