On 9 March 2018 at 15:36, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > [based on a patch from Alistair Francis <alistair.fran...@xilinx.com> > from qemu/xilinx tag xilinx-v2015.2] > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/sd/sd.c | 148 > +++++++++++++++++++++++++++++++++++++++++++++-------- > hw/sd/trace-events | 1 + > 2 files changed, 127 insertions(+), 22 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 235e0518d6..b907d62aef 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -124,6 +124,7 @@ struct SDState { > bool enable; > uint8_t dat_lines; > bool cmd_line; > + bool uhs_enabled;
Oh, and what's the difference between s->uhs_enabled = false (this patch) and s->uhs_mode = UHS_NOT_SUPPORTED (next patch) ? Do we need both? If so, a comment noting the difference would help people to know which one various bits of code should be checking. thanks -- PMM