Hi Peter, Edgar. On 03/09/2018 06:03 PM, Peter Maydell wrote: > On 9 March 2018 at 15:36, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> [based on a patch from Alistair Francis <alistair.fran...@xilinx.com> >> from qemu/xilinx tag xilinx-v2015.2] >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > This should ideally have a Signed-off-by: from somebody @xilinx.com as > well as you, then.
The original commit is: https://github.com/Xilinx/qemu/commit/02d2f0203dd#diff-4875140dbdae36a175ad74d6af9bc342R607 commit 02d2f0203dd489ed30d9c8d90c14a52c57332b25 (tag: xilinx-v2015.2) Merge: aa351061db 732f348311 Author: Alistair Francis <alistair.fran...@xilinx.com> Date: Thu Jul 9 14:32:46 2015 -0700 PetaLinux QEMU v2015.2 Signed-off-by: Alistair Francis <alistair.fran...@xilinx.com> As you can see the changes are: - change magic by definitions (SD_FG_MIN, SD_FN_COUNT, SD_FN_COUNT), - used stw_be_p() in 2 places, - added tracing. So no logical change. Is that enough to add Alistair S-o-b? Thanks, Phil.