On 24 March 2018 at 19:24, Michael Davidsaver <mdavidsa...@gmail.com> wrote: > differences from ds1338 > > * Has alarms (not modeled) > * different control register (not modeled) > * smaller address space (0x20 vs. 0x40) > > Signed-off-by: Michael Davidsaver <mdavidsa...@gmail.com> > --- > hw/timer/ds-rtc.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c > index 5a4df1b115..e5da36cae8 100644 > --- a/hw/timer/ds-rtc.c > +++ b/hw/timer/ds-rtc.c > @@ -1,8 +1,9 @@ > /* > - * MAXIM DSRTC I2C RTC+NVRAM > + * MAXIM/Dallas DS1338 and DS1375 I2C RTC+NVRAM
Ah, if you're going to change this to this text here, you should just leave it reading DS1338 in the earlier patch. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
