On 24 March 2018 at 19:24, Michael Davidsaver <mdavidsa...@gmail.com> wrote: > This series generalizes the ds1338 model to also support the ds1375. > As previously, only the time of day registers are modeled. This > series is largely a do-over wrt. my previous series. This time I > started with incremental changes from the existing ds1338 model, and only > add support for the ds1375 (which I care about). > > I've added a more thorough test of the time of day function, covering > reading and setting in both 12 and 24 hour mode. This corrects two > (practically inconsequential) bugs with the handling of 12 hour mode, > and day of the week. > > In an attempt to address concerns about false positive test failures > in CI builds, instead of comparing the parts of 'struct tm' seperately > I've changed the logic of the tests to compare the difference between > the expected and actual time in seconds. The threshold is 30 seconds > when run with 'gtester -m quick', and 1 second otherwise. > > Comparision of day of the week is still exact, so there is a chance of > a false positive if the test is running across midnight UTC.
Hi; sorry it took me a while to get to reviewing this patchset. I think I've now reviewed all the non-testcase parts of it. thanks -- PMM
