On 21 June 2018 at 02:53, Richard Henderson
<richard.hender...@linaro.org> wrote:
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> target/arm/helper.h | 5 ++
> target/arm/translate-sve.c | 18 +++++++
> target/arm/vec_helper.c | 96 ++++++++++++++++++++++++++++++++++++++
> target/arm/sve.decode | 8 +++-
> 4 files changed, 126 insertions(+), 1 deletion(-)
>
> +void HELPER(gvec_sdot_idx_b)(void *vd, void *vn, void *vm, uint32_t desc)
> +{
> + intptr_t i, j, opr_sz = simd_oprsz(desc), opr_sz_4 = opr_sz / 4;
> + intptr_t index = simd_data(desc);
> + uint32_t *d = vd;
> + int8_t *n = vn, *m = vm;
> +
> + for (i = 0; i < opr_sz_4; i = j) {
> + int8_t m0 = m[(i + index) * 4 + 0];
> + int8_t m1 = m[(i + index) * 4 + 1];
> + int8_t m2 = m[(i + index) * 4 + 2];
> + int8_t m3 = m[(i + index) * 4 + 3];
> +
> + j = i;
> + do {
> + d[j] += n[j * 4 + 0] * m0
> + + n[j * 4 + 1] * m1
> + + n[j * 4 + 2] * m2
> + + n[j * 4 + 3] * m3;
> + } while (++j < MIN(i + 4, opr_sz_4));
> + }
> + clear_tail(d, opr_sz, simd_maxsz(desc));
> +}
Maybe I'm just half asleep this afternoon, but this is pretty
confusing -- nested loops where the outer loop's increment
uses the inner loop's index, and the inner loop's conditions
depend on the outer loop index...
> diff --git a/target/arm/sve.decode b/target/arm/sve.decode
> index 0b29da9f3a..f69ff285a1 100644
> --- a/target/arm/sve.decode
> +++ b/target/arm/sve.decode
> @@ -722,7 +722,13 @@ UMIN_zzi 00100101 .. 101 011 110 ........ .....
> @rdn_i8u
> MUL_zzi 00100101 .. 110 000 110 ........ ..... @rdn_i8s
>
> # SVE integer dot product (unpredicated)
> -DOT_zzz 01000100 1 sz:1 0 rm:5 00000 u:1 rn:5 rd:5
> +DOT_zzz 01000100 1 sz:1 0 rm:5 00000 u:1 rn:5 rd:5
> ra=%reg_movprfx
Should this have been in the previous patch ?
> +
> +# SVE integer dot product (indexed)
> +DOT_zzx 01000100 101 index:2 rm:3 00000 u:1 rn:5 rd:5 \
> + sz=0 ra=%reg_movprfx
> +DOT_zzx 01000100 111 index:1 rm:4 00000 u:1 rn:5 rd:5 \
> + sz=1 ra=%reg_movprfx
>
> # SVE floating-point complex add (predicated)
> FCADD 01100100 esz:2 00000 rot:1 100 pg:3 rm:5 rd:5 \
> --
> 2.17.1
thanks
-- PMM
